Previously, the config was bindmounted inside the chroot only for hooks
from the config dir, now it is done earlier so it is available for all
hooks.
Note that it is now also done if there are no hooks, but this is
probably enough of an exception case to not warrant the extra plumbing
required to detect the case (and doing an extra bindmount shouldn't
really hurt anyway...).
lb_chroot_hooks would copy the hooks to run to
chroot/root/lb_chroot_hooks, but then try to run them from chroot/root
(which obviously fails). This means lb_chroot_hooks has not been working
for hooks from /usr/share/live/build/hooks since lb_chroot_hooks was
added in revision e4793268. Running hooks from the config directory was
unaffected.
Apparently, dash doesn't expand shell patterns within a quoted string,
whereas bash does. We can't remove the quoting entirely, though, since
that would cause problems when $LB_BASE or $_HOOK contains spaces (note
that $_HOOK can probably never contain spaces, but let's handle it just
in case). Only quoting the expansion of $LB_BASE and $_HOOK, but not the
shell pattern should make the hooks work with both bash and dash again.
Previously, there were a couple of hooks that were automatically run
for some image flavours. This came back from the old days when we
had to deconfigure gdm and enable kdm explicitly for kde images.
After lenny, this hack was not needed anymore, and there's not much
sense to keep the mechanism in place at all. Better, let's treat all
images the same way wrt/ hooks and don't do special automagics.
The only images that is of concern of are minimal and stripped
which we don't build by default anyway. This also stopps confusing
others.
Matthijs Kooijman
Daniel Baumann
Cody A.W. Somerville
liandro sg