manuel/live-build
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
c53a949325
live-build/scripts/build
History
Lyndon Brown c53a949325 firmware: fix possible duplication in firmware package lists (inefficiency) 
where multiple archive areas are used, the code here on each loop is:
  1) fetching the archive area contents file (compressed)
  2) **appending** the output to that of the previous loop
  3) searching the file for firmware references, adding to the list

since it appends rather than replaces, entries found in each loop get
re-added on each subsequent loop, resulting in duplication in the
resulting list

below I evaluate the possible solutions to explain why I chose the one
I chose, however the reader should not waste too much time worrying about
whether one of the other solution would have actually been better because
things are changed significantly in further commits shortly!

possible solutions:
  a) switching to output (>) rather than append (>>), but this might fail
     against an existing file
  b) removing the file on each loop, but this will complicate any future
     caching improvements that might be made here (currently the files are
     always deleted and thus downloaded fresh)
  c) allow the appending, evaluating the complete file after the loop

solution C warrants consideration of disk space consumption; currently the
compressed 'main' archive (for sid on amd64) expands to 592.3 MB (feb-2020),
'contrib' is 3.1 MB, and 'non-free' is 18.5 MB.

solution C was chosen here; the difference of accumulated file size vs.
max-single was minor enough to not be of particular concern (~613 vs.
~592 MB).

Gbp-Dch: Short
Closes: #952906
2020-03-05 22:13:57 +00:00
..
binary help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
binary_checksums help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
binary_chroot help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
binary_disk help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
binary_grub-efi cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
binary_grub-legacy cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
binary_grub-pc cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
binary_hdd cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
binary_hooks help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
binary_includes help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
binary_iso cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
binary_linux-image help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
binary_loadlin cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
binary_loopback_cfg help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
binary_manifest help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
binary_memtest cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
binary_netboot help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
binary_onie binary_onie: fix lack of newline on error 2020-03-05 21:04:23 +00:00
binary_package-lists cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
binary_rootfs cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
binary_syslinux cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
binary_tar help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
binary_win32-loader cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
binary_zsync cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
bootstrap help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
bootstrap_archives cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
bootstrap_cache help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
bootstrap_debootstrap fix missing use of echo helpers 2020-03-05 21:04:22 +00:00
build help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_apt help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_archives cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
chroot_cache help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_debianchroot help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_devpts help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_dpkg help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_firmware firmware: fix possible duplication in firmware package lists (inefficiency) 2020-03-05 22:13:57 +00:00
chroot_hacks help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_hooks cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
chroot_hostname help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_hosts help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_includes help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_install-packages cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
chroot_interactive help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_linux-image help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_package-lists cache: clarify and simplify package cache save/restore 2020-03-05 22:09:20 +00:00
chroot_preseed help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_proc help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_resolv help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_selinuxfs help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_sysfs help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_sysv-rc help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
chroot_tmpfs help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
clean help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
config help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
efi-image fix indentation 2020-03-05 11:29:01 +00:00
grub-cpmodules fix indentation 2020-03-05 11:29:01 +00:00
installer help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
installer_debian-installer firmware: fix possible duplication in firmware package lists (inefficiency) 2020-03-05 22:13:57 +00:00
installer_preseed help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
source help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
source_checksums help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
source_debian help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
source_disk help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
source_hdd help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
source_hooks help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
source_iso help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
source_live help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00
source_tar help/usage: fix overly complex script description handling 2020-03-05 20:48:49 +00:00